Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DataFrame indexing error in RTS-GMLC parser #251

Merged

Conversation

darrylmelander
Copy link
Collaborator

Fixes # .

The RTS-GMLC parser references a particular DataFrame cell by row key where it should reference by row position. The test didn't catch this because the first row of the data frame has a key of 0 in the RTS-GMLC data we test against. That isn't guaranteed to the case in other data sets.

Summary/Motivation:

Changes proposed in this PR:

  • Fix indexing

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@bknueven bknueven merged commit 2828eb7 into grid-parity-exchange:main Nov 13, 2021
@darrylmelander darrylmelander deleted the rts-gmlc-indexing-error branch November 15, 2021 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants