Adding reset after pre-lp warmstart loop #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bknueven
force-pushed
the
reset_after_warmstart
branch
from
914c822 to
a543c7f
Compare
| # the warmstart basis is typically | ||
| # worse than useless. If the solver | ||
| # implements it, reset the solver. | ||
| solver.reset() |
There was a problem hiding this comment.
Won't this cause an error for anything other than the gurobi persistent interface?
There was a problem hiding this comment.
I thought so for the longest time as well, but this is actually a method on the OptSolver base class:
https://github.com/Pyomo/pyomo/blob/5.7.1/pyomo/opt/base/solvers.py#L752-L756
It would be better if the other persistent solvers implemented this method, but obviously that needs to be updated in Pyomo. In any case, it doesn't seem to do any harm on solvers that aren't gurobi persistent.
There was a problem hiding this comment.
I actually did not know that existed, haha!
michaelbynum
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...for lazy PTDFs in unit commitment.