Add Gradle 8 Test Build #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boris-petrov
force-pushed
the
feature/gradle8
branch
from
8340ded to
9d1b16c
Compare
Signed-off-by: Falco Duersch <[email protected]>
| @@ -3,7 +3,7 @@ geckoDriverVersion = 0.29.1 | |||
| geckoDriverPlatform = macos | |||
| gradle_download_task_version = 3.4.3 | |||
| commons_configuration_version = 1.10 | |||
| gebVersion=2.3.1 | |||
| gebVersion=5.0 | |||
There was a problem hiding this comment.
I saw you downgraded Geb's version from 5.1 to 5.0 (above in the GH Actions script - but I changed it so that's why I'm asking here). What was the problem?
There was a problem hiding this comment.
Ah, very very good catch. I accidentally undid my own dep upgrades from 126fcc3 when copy-and-pasting the CI workflow from Gretty 3.
I'll give it a new try, actually we went back on both, geb and spock.
So it's probably spock_version = 2.3-groovy-3.0 and gebVersion = 5.1 to get back to the state before this PR (without further upgrading).
f4lco
added a commit
that referenced
this pull request
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.