Add missing Groovy dependencies to the classpaths of Gretty Products #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d product runner fixes #238
|
Seems great, thanks! So my initial thought was right. Thanks for fixing and trying it out. |
|
Indeed @boris-petrov, your comment was sending me the right way. tbh, this made a patch 10x more probable, because I did not have to get a foothold myself on code I hadn't worked on before, so many thanks 👍 |
| @@ -89,6 +89,7 @@ class GrettyPlugin implements Plugin<Project> { | |||
|
|
|||
| project.dependencies { | |||
| grettyStarter "org.gretty:gretty-starter:$grettyVersion" | |||
| grettyStarter ProjectUtils.getCurrentGroovy(project).dependencies | |||
There was a problem hiding this comment.
@f4lco - I'm using gradle-versions-plugin to check for dependency updates. Ever since updating to Gretty 3.0.7 which contains this change, I started getting these "possible updates":
- org.codehaus.groovy:groovy-cli-commons [3.0.8 -> 3.0.9]
https://groovy-lang.org
- org.codehaus.groovy:groovy-json [3.0.8 -> 3.0.9]
https://groovy-lang.org
I don't have these libraries in my project. I believe this is caused by the line I'm commenting on. Why was it added, are you sure that the rest of the changes in the PR are not enough for what it tries to fix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I must say I am very unfamiliar with Gretty's product code, but I could test this patch successfully with the instructions from #238 and the gretty-sample project. The number of classpaths Gretty maintains is mind-boggling.
Apparently, the fix consists of adding the Groovy dependencies:
Firstly, to the runner classpath for Gretty products. The entry was missing, because we duplicated code in between the normal Gretty execution and products. When we added the Groovy version selection at runtime, we forgot to update the product code. Commit 72deb14 removes the duplication.
Second, we add the Groovy dependencies to the configuration of the starter, the component that spawns runners for products.