Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include dataset name in trainer uploads. #21

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Conversation

kboyd
Copy link
Contributor

@kboyd kboyd commented Oct 6, 2022

Add original file name to data sources uploaded as part of trainer projects. This helps disambiguate the data sources from multiple trainer runs where previously they were always named trainer_0.csv, trainer_1.csv, etc.

Also fixes StrategyRunner to not silently swallow all ApiExceptions when submitting a job, so errors not associated with max job limit are still thrown and surfaced to the user.

@kboyd kboyd requested a review from johntmyers October 6, 2022 22:20
@zredlined zredlined merged commit 3317a21 into main Oct 11, 2022
@zredlined zredlined deleted the kb/artifact-names branch October 11, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants