-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle nested lists of nested objects #154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some questions/ nitty comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interested in some of the answers to Matt's questions, but otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one suggestion for potential simplification.
Fixes a bug where relational JSON could not recompose lists of nested objects. See unit test for example. I've also filed a backlog ticket to improve how we handle the edge case documented in the second unit test.
This diff is pretty noisy because I wanted to add some comments / refactors / naming improvements to help explain what's going on and reduce the amount of time spent just figuring out what's going on next time we have to visit this. The actual fix was shockingly trivial, I will call it out inline.