Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency tweaks #145

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Dependency tweaks #145

merged 1 commit into from
Jul 28, 2023

Conversation

mikeknep
Copy link
Contributor

  • numpy is imported explicitly in the relational.extractor and relational.json modules, but had not been declared an official dependency (it was getting pulled in transitively by pandas)
  • rename dev/test requirements file to be consistent with our other public Python repos (gretel-client, gretel-synthetics)
  • similarly, take out the -r requirements.txt helper and just explicitly install both files during workflow setup
    • I believe we could get away with only installing -r test-requirements.txt explicitly, and then the following pip install -e . line would handle installing the production/runtime requirements thanks to install_requires in setup.py. I don't have a strong opinion here.
  • alphabetizing is good for you

Copy link
Contributor

@pimlock pimlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alphabetizing is good for you

😅

@mikeknep mikeknep merged commit 7b4d9c6 into main Jul 28, 2023
@mikeknep mikeknep deleted the deps branch July 28, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants