Re-add source_ prefix to archived source files #140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the PR moving source data from memory to disk, I introduced a bug in the creation of the source data archive (
source_tables.tar.gz
) that broke the restore-from-backup functionality.Original backup-and-restore behavior
source_{table}.csv
Bug from previous PR
Since the tables now exist on disk and we only store pointers to them in memory, we don't need to call
dataframe.to_csv
; instead we just add the existing local files to the archive. The problem is that the filenames of the archived files changed—they no longer had thesource_
prefix but were instead just{table}.csv
:Consequently, when
restore
pulls down and unpacks the archive, it looks for files that do not exist (e.g. it tries to findsource_users.csv
but the file in the archive is justusers.csv
).The fix (this PR)
Add the
source_
prefix to each table filename when adding it to the archive.