fix: nested json table string length #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where we are parsing nested json with lengthy key strings the combination of key strings in the breadcrumb based table name string would result in an error when trying to train the model due to a maximum json filename length of 128 chars. Here we utilize the already existing make_suffix function (which ensures no sanitized_str collisions) and we truncate the length of the table name to ensure we do not exceed the 128 char limit.
|
Let me know if I am missing anything in the unit test coverage. I think the tests I added should cover us but I wasn't sure if there were any other existing tests that would benefit from having the real |
Instead of sanitizing the full json path to an invented table, we create a table name based on the producer table with a uuid to prevent collisions, and we map the full json path to the unique table string.
When nested json structures are extracted to individual dataframes they will be written to resulting individual tables. Since we are creating table names with the convention <producer_table>_invented_<uuid> we now store the mapping details for tables in the producer table's debug summary, as well as the json breadcrumb path in each invented table's individual debug summary.
|
The latest commits incorporate feedback gathered via slack to name invented tables |
mikeknep
reviewed
Jul 17, 2023
mikeknep
reviewed
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where we are parsing nested json with lengthy key strings the combination of key strings in the breadcrumb based table name string would result in an error when trying to train the model due to a maximum json filename length of 128 chars. Here we utilize the already existing make_suffix function (which ensures no sanitized_str collisions) and we truncate the length of the table name to ensure we do not exceed the 128 char limit.