fix: unit test errors on new mac m2 #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A large portion of the unit tests were failing for me with a fresh clone of this repository on a brand new m2 macbook. Upon further digging I was able to identify sqlite3.connect as the issue. Specifically it wasn't honoring the uri params passed in the connection string and so it was creating a db on disk rather than an in memory shared db. This caused unit tests to throw errors. ref: https://stackoverflow.com/questions/62502827/python-how-to-connect-sqlalchemy-to-existing-database-in-memory
|
Benjamin McCown seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
I went ahead and signed the CLA. Not sure how to trigger the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A large portion of the unit tests were failing for me with a fresh clone of this repository on a brand new m2 macbook. Upon further digging I was able to identify sqlite3.connect as the issue. Specifically it wasn't honoring the uri params passed in the connection string and so it was creating a db on disk rather than an in memory shared db. This caused unit tests to throw errors.
ref: https://stackoverflow.com/questions/62502827/python-how-to-connect-sqlalchemy-to-existing-database-in-memory