Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bq support plus better random and contiguous fallback #125

Merged
merged 5 commits into from
Jun 16, 2023
Merged

bq support plus better random and contiguous fallback #125

merged 5 commits into from
Jun 16, 2023

Conversation

johntmyers
Copy link
Contributor

Use contiguous as the default mode. When using random try using both func.random() and func.rand() if either of those fails just fall back to contiguous mode, bq working now:

image

mckornfield
mckornfield approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@mckornfield mckornfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one food for thought item but otherwise lg

@johntmyers johntmyers merged commit 0e2c8b8 into main Jun 16, 2023
@johntmyers johntmyers deleted the jm/sample-mode-bq branch June 16, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeknep mikeknep mikeknep approved these changes

@mckornfield mckornfield mckornfield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johntmyers @mikeknep @mckornfield