Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation warnings
Adds deprecation warnings guiding the user away from:
...and towards:
Each line in the first block above will print a deprecation warning (but will continue to work). In a future release we'll remove the
gretel_model
parameter completely and makeconfig
a required argument totrain_synthetics
.Bugfix
In the previous PR adding custom synthetics config support, I reused the existing
supported_models
property of the strategies for config validation. However, those values are essentially constants specific to Relational Trainer (thegretel_model
param specifically); in the cases of amplify and actgan, they overlap with the model key we expect to see in a config, but that is not the case for:The fix here is a bit verbose but only temporarily—we'll remove the
supported_gretel_models
property when we remove thegretel_model
param.