Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some relational samples #347

Merged
merged 5 commits into from
Feb 2, 2024
Merged

Add some relational samples #347

merged 5 commits into from
Feb 2, 2024

Conversation

aray12
Copy link
Contributor

@aray12 aray12 commented Jan 30, 2024

Problem

We want to be able to create blueprints that use sample connections provided to ease the onboarding process. This is required to create blueprints that use databases because all database workflows are powered by connections, as opposed to a sample static file.

Solution

Create 2 new blueprints that use a new sampleConnection field and update unit tests to support this field.

Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gretel-blueprints ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 6:19pm

@aray12 aray12 requested a review from thesteady February 1, 2024 17:31
@aray12 aray12 marked this pull request as ready for review February 1, 2024 17:31
@aray12 aray12 requested a review from gracecvking February 1, 2024 17:50
Copy link
Contributor

@gracecvking gracecvking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change request to have the default transform config be transform v2, but I'm marking this as approved for I don't block you merging after that change is made.

use_cases/gretel.json Outdated Show resolved Hide resolved
@aray12 aray12 merged commit 527abdc into develop Feb 2, 2024
5 checks passed
@aray12 aray12 deleted the alex/INT-1689 branch February 2, 2024 21:19
aray12 added a commit that referenced this pull request Feb 6, 2024
# Problem

We want to be able to create blueprints that use sample connections provided to ease the onboarding process. This is required to create blueprints that use databases because all database workflows are powered by connections, as opposed to a sample static file.

# Solution

Create 2 new blueprints that use a new `sampleConnection` field and update unit tests to support this field.
aray12 added a commit that referenced this pull request Feb 15, 2024
* Add some relational samples (#347)

# Problem

We want to be able to create blueprints that use sample connections provided to ease the onboarding process. This is required to create blueprints that use databases because all database workflows are powered by connections, as opposed to a sample static file.

# Solution

Create 2 new blueprints that use a new `sampleConnection` field and update unit tests to support this field. Also reorg a bit so there aren't duplicate blueprints and the homepage has the desired use cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants