Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIDY] Remove images from blueprint card architecture #337

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

thesteady
Copy link
Contributor

Problem

We recently shifted to using icons for blueprint cards in Console instead of the larger header images. This code has made it to production in Console, so we can remove the no-longer used images.

Solution

Delete the header images (keeping ones used by details files), remove the references from the blueprint cards, and remove the test that asserted the image field was present and that the images references were in their folder.

Copy link

vercel bot commented Jan 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gretel-blueprints ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2024 3:58pm

@thesteady thesteady marked this pull request as ready for review January 12, 2024 16:38
Copy link
Contributor

@danielleali danielleali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@thesteady thesteady merged commit 778c742 into develop Jan 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants