-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pomodoro: Overhaul block #2020
base: master
Are you sure you want to change the base?
pomodoro: Overhaul block #2020
Conversation
With #2032 we won't need to expose two values for the current pomodoro number. |
195523e
to
5b592ac
Compare
Hey, is there any update on this PR? I wanted to the timers to the configuration, but saw that a PR was already in place. |
Once #2032 is merged we can review this change @aadilshabier |
@MaxVerevkin are we ready to merge this? |
Since we are introducing separate |
I think we need to keep |
Although by adding removing the |
Changes:
The previous config will still be valid with the current config since there are new formats for the various states.
Ideally this will be merged after the format duration is added so that we don't have an additional inflection point in the config.