pomodoro: Overhaul block #2020
Open
pomodoro: Overhaul block #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With #2032 we won't need to expose two values for the current pomodoro number. |
bim9262
force-pushed
the
pomodoro
branch
2 times, most recently
from
195523e
to
5b592ac
Compare
Merged
|
Hey, is there any update on this PR? I wanted to the timers to the configuration, but saw that a PR was already in place. |
|
Once #2032 is merged we can review this change @aadilshabier |
MaxVerevkin
reviewed
Sep 9, 2024
|
@MaxVerevkin are we ready to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
The previous config will still be valid with the current config since there are new formats for the various states.
Ideally this will be merged after the format duration is added so that we don't have an additional inflection point in the config.