Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup projects and environment variables #7

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

lizard-boy
Copy link

@lizard-boy lizard-boy commented Nov 1, 2024

cleanup projects and use modern environment variables.

Greptile Summary

Updates environment variable prefixes from 'COMPlus_' to 'DOTNET_' across benchmark and test files to align with modern .NET runtime configuration practices.

  • Updated all hardware intrinsics configuration constants in Config.HwIntrinsics.cs from COMPlus_ to DOTNET_ prefix
  • Modified benchmark result documentation in all Shuffle/Pad benchmark files to reflect new DOTNET_ prefix
  • Updated FeatureTestRunner environment variable handling to use DOTNET_ prefix
  • Benchmark results remain consistent between old and new prefix implementations
  • Note: Comment referencing 'COMPlus equivalents' in FeatureTestRunner.cs needs updating for consistency

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants