-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing #1189 #1195
fixing #1189 #1195
Conversation
Part of the fix for #1189.
Added code to emit \GreSetLargestClef at the top of the score.
I added the C part. Running the tests, I think the results look as they should, given the code, but the fix-1192 test shows a weird edge case, where the clef change to a larger clef occurs on the last (in this case, the only) line, adding space to the first clef which really doesn't align it with anything below. I presume something similar would occur if the clef changes from C to F to C on the same line. |
Thanks a lot! Indeed the current mechanism doesn't cover the kind of edge cases you're describing, but they should be very rare and easy to fix in gabc. I'll run the tests |
Perhaps how to fix this edge case in gabc should be documented. I'll admit I have no idea how you'd do that. |
Strange: trying to run the tests, I have a lot of message like
and all tests fail, although the |
Must be the test scripts. I'll look into it... Maybe a locale issue. |
It's definitely a locale problem. |
I set |
that solved the problem, thanks! |
Ok, I think this is ready to review |
\end{argtable} | ||
|
||
\macroname{\textbackslash grelocalbolshiftcleftype}{\{\#1\}}{gregoriotex-spaces.tex} | ||
Equivalent of \verb=\grebolshiftcleftype= but valid only until the next end of a score, and with more options. This can be used inside gabc for corner cases like different alignment on a score taking two pages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is the user documentation, I would explicitly mention that this should be used in a <v>texverb</v>
in gabc.
I can't review the C code since I wrote it, but I'm done reviewing the TeX code and documentation. |
done, thanks |
Looks fine to me. If you're OK with the C code, then I think this can be merged. |
Thanks! |
This should fix #1189, currently only the TeX part is here