Fix 1138 #1166
Merged
Fix 1138 #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…note is near the clef. Part of the implementation for #1138.
Added an argument to \GreSetInitialClef indicating whether the first note is near the clef
| if (glyph->u.notes.glyph_type == G_PODATUS && note->next) { | ||
| note = note->next; | ||
| } | ||
| if (!(note->u.note.pitch > clef_pitch - 4 |
There was a problem hiding this comment.
I think it would be better to change this to:
if (note->u.note.pitch < clef_pitch - 3
|| note->u.note.pitch > clef_pitch + 3) {
There was a problem hiding this comment.
Indeed. I wonder if something could also be checked for high keys and above line things...
|
Looks good to me... do you know if it changed any test? |
|
no test changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1138.