-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cavum glyphs #1143
Cavum glyphs #1143
Conversation
Part of the implementation for gregorio-project#844.
Part of the implementation for gregorio-project#844.
Thanks, that's quite impressive! I'll review it tonight |
I'm getting a warning in this branch, but it may come from another PR:
|
Well, apart from this tiny warning everything looks really perfect! Thank you very much for this, I think this is a great feature that will allow gregorian chant typography to go one step further. Ok for me to be merged (with or without the fix for the warning, it can be for another PR) |
It's most likely from here. The cavum changes reduced a lot of "special" glyph transformation code. I will try to fix it tonight and add the tests you requested. |
Part of the implementation for gregorio-project#844.
I made the changes and added the tests. Please review at your leisure. |
Perfect, thanks a lot! |
Implemented expanded set of cavum glyphs (#844).
Note: this is a seriously big and potentially breaking pull request and should not be pulled into 4.2.
Tests obviously change because of this.
Please review and merge if satisfactory.