-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
low Custos overlapping with text (edge case) #961
Comments
Looking at the results further, it does appear to be just with the custos and also occurs with all staves. |
Should the height be increased if only the custos at the right of the line might overlap the text? |
If end of line shifts are enabled, then the height should change, even for an end of line custos, because then the text might overlap with a low custos (the end of line shifts are specifically designed to allow text to go under that custos). If end of line shifts are disabled, then the text cannot go under the end of line custos, so there is no need for the height to change for it. |
I don't have a strong opinion on this, I was thinking to consider the custos height in all cases, but it's certainly best to consider it only if it overlaps with the text yes |
In gabc-output/lines/2-lines, 3-lines and 5-lines the low notes an the lyrics overlap in the third line. Is this because of they are custos, or because there's a problem with the line height calculations?
The text was updated successfully, but these errors were encountered: