Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

low Custos overlapping with text (edge case) #961

Closed
rpspringuel opened this issue Feb 24, 2016 · 5 comments
Closed

low Custos overlapping with text (edge case) #961

rpspringuel opened this issue Feb 24, 2016 · 5 comments
Assignees
Labels
Milestone

Comments

@rpspringuel
Copy link
Contributor

In gabc-output/lines/2-lines, 3-lines and 5-lines the low notes an the lyrics overlap in the third line. Is this because of they are custos, or because there's a problem with the line height calculations?

@eroux
Copy link
Contributor

eroux commented Feb 24, 2016

The result is

961

I don't think it's really serious, it's probably just with custos. Something else to document in the Known bugs section of the changelog for 4.1.

@eroux eroux added this to the 5.0 milestone Feb 24, 2016
@eroux eroux added the bug label Feb 24, 2016
@rpspringuel
Copy link
Contributor Author

Looking at the results further, it does appear to be just with the custos and also occurs with all staves.

@eroux eroux changed the title Notes and lyrics overlapping in 2-, 3-, & 5-line score low Custos overlapping with notes (edge case) Mar 2, 2016
@rpspringuel rpspringuel modified the milestones: 4.1.1, 5.0 Mar 3, 2016
@eroux eroux modified the milestones: 4.2, 4.1.1 Mar 3, 2016
@rpspringuel rpspringuel changed the title low Custos overlapping with notes (edge case) low Custos overlapping with text (edge case) Mar 4, 2016
@henryso
Copy link
Contributor

henryso commented Mar 11, 2016

Should the height be increased if only the custos at the right of the line might overlap the text?

@rpspringuel
Copy link
Contributor Author

If end of line shifts are enabled, then the height should change, even for an end of line custos, because then the text might overlap with a low custos (the end of line shifts are specifically designed to allow text to go under that custos).

If end of line shifts are disabled, then the text cannot go under the end of line custos, so there is no need for the height to change for it.

@eroux
Copy link
Contributor

eroux commented Mar 11, 2016

I don't have a strong opinion on this, I was thinking to consider the custos height in all cases, but it's certainly best to consider it only if it overlaps with the text yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants