-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
problems when final syllable has no notes #1205
Comments
(originally from this thread) |
The problem disappears if |
I'm not sure I'm the best person to opine on that, but I can try to make the change and see what tests it breaks. I take it this is for 5.0? |
Well, I would prefer 4.2, but if you think this is too much, then 5.0 is fine |
No, I can do it in 4.2, but the milestone is not set, so I wasn't sure. |
From reading the description, I think this might conflict with #1116. |
If the check is only for syllables that follow, this breaks |
* release-4.2: Update Version Number Suppressed \GreLastOfScore if only no-element syllables follow it. Fixes gregorio-project#1205. Cherry pick fc54014 Bump Copyright year. Change package loading order to account for TeXLive 2016 Cherry pick 54bc8b8 Load PlainTeX version of xstring Cherry pick ca8b226 Update Version number CHANGELOG entries Fix issue with custom spaces Reach the translation glyph node by traverse_id()
* release-4.2: Update Version Number Suppressed \GreLastOfScore if only no-element syllables follow it. Fixes gregorio-project#1205. Cherry pick fc54014 Bump Copyright year. Change package loading order to account for TeXLive 2016 Cherry pick 54bc8b8 Load PlainTeX version of xstring Cherry pick ca8b226 Update Version number CHANGELOG entries Fix issue with custom spaces Reach the translation glyph node by traverse_id()
* release-4.2: (72 commits) Added a test for the suppression of \GreLastOfScore. Tests gregorio-project/gregorio#1205. Updated test harness to handle gregorio executable with version number. Tests gregorio-project/gregorio#1197. Updated tests to match the oriscus orientation at unison change. Tests gregorio-project/gregorio#1177. Small inconsistency Added a test to exercise per-line dimension changes. Tests gregorio-project/gregorio#1156. Accepted test results after merge. accept tests for fix-1144 accept changes for #1169 accept tests for 1146 accept tests for #1146 accept changes for fix-1138 changes for fix-1137 Accepted updated results after merging gregorio-project/gregorio#1154. Tests gregorio-project/gregorio#1153. Accepted updated results after merge of release-4.2 into fix-1155. accept changes for fix-1152 add tests for 1155 accept tests for fix-1155 Accepted expectations after #1148. Tests gregorio-project/gregorio#1145. Added the test from gregorio-project/gregorio#1141. Added the test from gregorio-project/gregorio#1139. ...
* master: Update known failures in README Added a test for the suppression of \GreLastOfScore. Tests gregorio-project/gregorio#1205. Updated test result Change luatex-ja test to have its own gabc file and modify to test for proplem
The following example:
produces the strange result:
I think this is because of the way
\GreLastOfScore
is handled...The text was updated successfully, but these errors were encountered: