Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reducing notes-bar spacings when notes far from the bar #1144

Closed
eroux opened this issue Jun 15, 2016 · 8 comments
Closed

reducing notes-bar spacings when notes far from the bar #1144

eroux opened this issue Jun 15, 2016 · 8 comments

Comments

@eroux
Copy link
Contributor

eroux commented Jun 15, 2016

In this extract of a real-life example:

name:Redemptor noster;
%%
(c4) tres(f_g) pú(gh)e(gf)ros(d_f!/ddoc) (,) de(c) ca(d)mí(f)no(f) (::)

giving this output:

bug1

the notes around the bar could be close to each other because they are far from the bar.

This would introduce:

  • bar@virgula@standalone@notext@lownotes
  • bar@minima@standalone@notext@lownotes
  • bar@virgula@standalone@text@lownotes
  • bar@minima@standalone@text@lownotes

(no emergency for this one!)

@henryso
Copy link
Contributor

henryso commented Jun 15, 2016

While it's fresh in your mind, what is considered a low note? Should it be configurable? If so, what should be the default?

@eroux
Copy link
Contributor Author

eroux commented Jun 15, 2016

I think notes from a to f could be considered low... I don't think it needs special configuration no...

@jakubjelinek
Copy link
Contributor

How would more complex neumes be treated though? E.g. for pes it is low note if the upper note is low note, what about clivis, etc.?

@henryso
Copy link
Contributor

henryso commented Jun 15, 2016

@eroux I'm assuming you mean for a 4-line staff, and that this should change appropriately for 2-, 3-, or 5-line staves.

@jakubjelinek I think in the general case, you would need to go by the last note in the glyph before and the first note in the glyph after, unless the glyph after is a pes, in which case you go by the second note.

@eroux
Copy link
Contributor Author

eroux commented Jun 15, 2016

@henryso indeed, and you're right for notes determination

@jakubjelinek
Copy link
Contributor

Yeah, though not just for pes, but also e.g. for liquescences - for feh~ h, but for fed~ e, not d.

@eroux
Copy link
Contributor Author

eroux commented Jun 15, 2016

That's true indeed...

@henryso
Copy link
Contributor

henryso commented Jun 15, 2016

@jakubjelinek Agreed, it's more complex than I thought.

eroux added a commit that referenced this issue Jun 28, 2016
@eroux eroux mentioned this issue Jun 29, 2016
eroux added a commit that referenced this issue Jun 29, 2016
@eroux eroux closed this as completed Jun 29, 2016
rpspringuel added a commit to rpspringuel/gregorio that referenced this issue Jul 4, 2016
* commit 'f790c50299dcbf2d919e4459de8668ce6c269b19': (35 commits)
  Specifically noted which spaces may be altered by grechangenextscorelinedim.
  Added the ability to change a dimension for a given line in a score. Fixes gregorio-project#1156.
  1144: fix doc typos
  oops
  document spaces
  doc, fix small bug,
  Implemented distance check for notes around virgula and divisio minima.
  do not use alterationsadjustment on clef change, reduce it
  greciliae: fix small problem of joining line height
  doc
  fix gregorio-project#1169
  attempt to fix gregorio-project#1146
  TeX part of gregorio-project#1144
  Extended the nearness check to the first two notes of podatus, clivis, and porrectus.
  gregorio-project#1138: TeX and doc
  gregorio-project#1138: change default case
  gregorio-project#1137: fix case of podatus
  Added an argument to \GreSetInitialClef indicating whether the first note is near the clef. Part of the implementation for gregorio-project#1138.
  fix gregorio-project#1137
  Add documentation for recent Nabc vertical placement changes.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants