Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on downloading empty table as CSV #984

Merged
merged 1 commit into from
Oct 15, 2019

Conversation

bkiac
Copy link
Contributor

@bkiac bkiac commented Oct 4, 2019

Fixes #967
Similar to #929 without refactoring.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 77.339% when pulling 716350d on bkiac:master into b8bee52 on gregnb:master.

@gabrielliwerant gabrielliwerant added the needs review Useful to mark PRs for what's up next to review label Oct 8, 2019
@gabrielliwerant gabrielliwerant self-requested a review October 8, 2019 02:08
Copy link
Collaborator

@gabrielliwerant gabrielliwerant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good!

@gabrielliwerant gabrielliwerant added bug lgtm and removed needs review Useful to mark PRs for what's up next to review labels Oct 15, 2019
@gabrielliwerant gabrielliwerant merged commit 35f129d into gregnb:master Oct 15, 2019
waqasajaz pushed a commit to waqasajaz/mui-datatables that referenced this pull request Oct 31, 2019
lalong13 pushed a commit to lalong13/mui-datatables that referenced this pull request Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught TypeError when clicking on "Download CSV" with no data in the table
3 participants