adding button wrapper for icon

[michalica]

I want to improve accessbility of expandable rows in #969

[coveralls]

Coverage remained the same at 76.634% when pulling bbd17e4 on michalica:adding-button-wrapper into f0ea9e5 on gregnb:master.

[michalica]

Can you please include this PR in next release? @gabrielliwerant

[gabrielliwerant]

Always nice to improve accessibility, thanks for looking into this!

We should use IconButton instead of button here, as that keeps us in line with material standards and the look of the icon that we had before.

There's also an opportunity here to add a onKeyDown handler for activation via the enter key. If you wanted to add that, I would be happy to accept it, or I can provide that functionality separately myself, it's up to you.

[michalica]

I would be glad to work on this. I think pressing space or enter on focused element triggers onClick event by default. In our case, row will be expanded or collapsed. Do we need onKeyDown handler there?

[gabrielliwerant]

You are correct, it looks like the default is to trigger on space and enter.

Ok, so let's just switch it to IconButton and we should also disable it for the header or we'll have an odd looking empty header button as well. Something like disabled={isHeaderCell} should work.

[gabrielliwerant]

Beautiful! Thank you for the update.