Fix issue by properly checking for basic js objects and preserve displayed index #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuyShaanan
reviewed
Sep 27, 2019
|
Sorry about nagging - What is the release cycle of this lib / when should we expect this fix to land? |
gabrielliwerant
changed the title
gabrielliwerant
deleted the
bugfix/issue-963-use-displayed-rows-only-with-non-react-objects
branch
waqasajaz
pushed a commit
to waqasajaz/mui-datatables
that referenced
this pull request
Oct 31, 2019
…layed index (gregnb#964) * Fix issue by properly checking for basic js objects * Use displayed index to help preserve sorting arrangement
lalong13
pushed a commit
to lalong13/mui-datatables
that referenced
this pull request
Jan 15, 2020
…layed index (gregnb#964) * Fix issue by properly checking for basic js objects * Use displayed index to help preserve sorting arrangement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #963.
Also closes #973.