Fix invalid option deprecation checks #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `handleOptionDeprecation` function is being passed the original props instead of those with the default options merged in. This is causing false positive `console.error` output to be thrown. Example: Any table that doesn't include a `responsive` props option will see the `Invalid option value for responsive.` because the check isn't seeing the merged in default option.
gabrielliwerant
approved these changes
Sep 25, 2019
waqasajaz
pushed a commit
to waqasajaz/mui-datatables
that referenced
this pull request
Oct 31, 2019
The `handleOptionDeprecation` function is being passed the original props instead of those with the default options merged in. This is causing false positive `console.error` output to be thrown. Example: Any table that doesn't include a `responsive` props option will see the `Invalid option value for responsive.` because the check isn't seeing the merged in default option.
lalong13
pushed a commit
to lalong13/mui-datatables
that referenced
this pull request
Jan 15, 2020
The `handleOptionDeprecation` function is being passed the original props instead of those with the default options merged in. This is causing false positive `console.error` output to be thrown. Example: Any table that doesn't include a `responsive` props option will see the `Invalid option value for responsive.` because the check isn't seeing the merged in default option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
handleOptionDeprecationfunction is being passed the original props instead of those with the default options merged in. This is causing false positiveconsole.erroroutput to be thrown.Example:
Any table that doesn't include a
responsiveprops option will see theInvalid option value for responsive.because the check isn't seeing the merged in default option.