Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/Issue 365 #896

Merged
merged 2 commits into from
Sep 4, 2019
Merged

Bugfix/Issue 365 #896

merged 2 commits into from
Sep 4, 2019

Conversation

gabrielliwerant
Copy link
Collaborator

@gabrielliwerant gabrielliwerant commented Sep 4, 2019 •
edited
Loading

Fix #365 regression with certain options being overridden improperly.

@gabrielliwerant
Add failing test for empty rowsPerPageOptions
f8a5fff
@gabrielliwerant
Fix options overrides for initial table setup
e021001 
Use the same method as table update so that both approaches are now consistent.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 76.408% when pulling e021001 on bugfix/issue-365-options-regression into b61d06a on master.

@gabrielliwerant gabrielliwerant merged commit 2bd506d into master Sep 4, 2019
@gabrielliwerant gabrielliwerant deleted the bugfix/issue-365-options-regression branch September 4, 2019 22:51
@gabrielliwerant gabrielliwerant mentioned this pull request Sep 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

disable rowsPerPageOptions or feed it less than 3 values
2 participants
@gabrielliwerant @coveralls