Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 759 responsive options #867

Merged
merged 2 commits into from
Aug 29, 2019

Conversation

gabrielliwerant
Copy link
Collaborator

Closes #759, #580, and #234 (comment).

  • adds responsive option called scrollFullHeight which allows display of all rows (from a given page) in the browser without a max height
  • responsive scroll option has been deprecated and is being replaced with scrollMaxHeight

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 74.908% when pulling fb4044f on feature/issue-759-responsive-options into d1914e4 on master.

@JReinhold
Copy link
Contributor

Looks good. I'll try to find all the existing issues, and point them in this direction once it is merged.

@ShenLanJohn
Copy link

I used responsive: "scrollMaxHeight" in My code, but the table is getting smaller. where can I set maxHeight value?

@ShenLanJohn
Copy link

could you please help, how to change scrollMaxHeight default value in MUIDataTable?

@gabrielliwerant
Copy link
Collaborator Author

@ShenLanJohn This question has been addressed in some of the closed issues, so you may find your answer here https://github.com/gregnb/mui-datatables/issues?q=is%3Aissue+maxHeight+is%3Aclosed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why does the table have a max height when responsive is set to scroll?
4 participants