Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add searchProps #808

Closed
wants to merge 2 commits into from
Closed

Add searchProps #808

wants to merge 2 commits into from

Conversation

jagribble
Copy link

@jagribble jagribble commented Aug 2, 2019

One of the things that I can see is quite a problem with a lot of people with the search customization not being the best. So I have added the searchProps to option which spreads against the Seach text field.

This allows people to define their own props (onBlur, onChange etc.)

Would there be a chance of reviewing this soon as we kind of need this functionality soon @gregnb

@coveralls
Copy link

coveralls commented Aug 2, 2019

Coverage Status

Coverage remained the same at 74.963% when pulling 174a8bd on jagribble:master into 6740f71 on gregnb:master.

@gabrielliwerant
Copy link
Collaborator

There is a PR already open for an entire custom search render, which I think would handle your use cases as well, so I'd like to see how that goes first: #771.

Marking as duplicate for now, but we can revisit after the other PR if there is still a need for something like this.

@gabrielliwerant
Copy link
Collaborator

@jagribble The new option for custom search bars (customSearchRender) is available in 2.8.0. Does that feature satisfy your use case?

@gabrielliwerant
Copy link
Collaborator

@jagribble If you'd like to bring this PR up to date, I would like to consider adding it to the library, as it may solve some problems for people a bit more elegantly than a custom render solution.

Additionally, I think it would be good not to require specific properties here, and allow all props from an object to be spread to the component, as this matches similar features elsewhere.

@gabrielliwerant
Copy link
Collaborator

This has fallen out of date, and @patorjk offered to submit a new PR with this feature, so this is on hold for now.

@patorjk
Copy link
Collaborator

patorjk commented Jun 3, 2020

Feature added into v3 branch.

@patorjk patorjk closed this Jun 3, 2020
@patorjk patorjk mentioned this pull request Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants