Hide toolbar and select cells on printing #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patorjk
requested changes
Jun 1, 2020
There was a problem hiding this comment.
I'm open to this update for the v3 release of the table (which I'm currently putting together). However, I think I'd want this PR to focus solely on hiding the toolbar and select cells for printing.
It may be easier to work from the v3 branch. If you interested in putting something together for it please let me know. Also, sorry in the delay it has taken for this to get addressed.
|
I`ll fix those issues and submit a new PR soon |
Fix errors of the latest PR.
|
Sorry for taking so long... |
|
No worries. Updates for printing should be available in v3, which hopefully will be released within the next day or two (mostly now just need to finish up testing). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When printing, toolbar and select cells are visible and it's a not desired behavior on reports.