Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is valid date #1012

Closed
wants to merge 1 commit into from
Closed

is valid date #1012

wants to merge 1 commit into from

Conversation

wroughtec
Copy link

add check to see if object is a js date object

fixex #1011

is valid date
525ade3 
add check to see if object is a js date object
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 77.317% when pulling 525ade3 on native-finance:bugfix/issue-1011-date-in-cell into e8aa513 on gregnb:master.

@gabrielliwerant
Copy link
Collaborator

gabrielliwerant commented Oct 18, 2019 •
edited
Loading

I don't think we'll need this anymore, as I've changed to a console error in cases where an object is being used. Can you confirm?

Also, when the ability to use objects is prevented (to fix other issues), this will be a wontfix, as support for objects in the data structure is not planned at this time, and was never intended for use.

@gabrielliwerant gabrielliwerant added wontfix Support for this request is not planned at this time needs verification For issues that can't be reproduced or are otherwise unclear labels Oct 18, 2019
@patorjk patorjk closed this Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs verification For issues that can't be reproduced or are otherwise unclear wontfix Support for this request is not planned at this time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wroughtec @coveralls @gabrielliwerant @patorjk