Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Width on custom filter component #790

Closed
pkmnct opened this issue Jul 24, 2019 · 2 comments · Fixed by #791
Closed

Width on custom filter component #790

pkmnct opened this issue Jul 24, 2019 · 2 comments · Fixed by #791

Comments

@pkmnct
Copy link
Contributor

pkmnct commented Jul 24, 2019

Expected Behavior

FormControl should allow components to fill width
image

Current Behavior

FormControl limits the width of components
image

We are using React-Select within our project, and attempting to make a custom filter using it results in this.
pkmnct added a commit to pkmnct/mui-datatables that referenced this issue Jul 24, 2019
@pkmnct
Fix issue with custom component width
14aec9a 
Fix gregnb#790
@pkmnct pkmnct mentioned this issue Jul 24, 2019
Merged
@pkmnct pkmnct closed this as completed Jul 26, 2019
@pkmnct pkmnct reopened this Jul 26, 2019
gabrielliwerant pushed a commit that referenced this issue Aug 9, 2019
@pkmnct @gabrielliwerant
Fix issue with width on custom filter component (#791)
aaf8dac 
* Fix issue with custom component width

Fix #790

* Switch to correct FormControl

* Use Material UI prop for fullwidth, not style

* Remove old flex styles
@emil-alexandrescu
Copy link

@pkmnct How did you solve overflow issue?

@pkmnct
Copy link
Contributor Author

pkmnct commented Aug 13, 2019

@emil-alexandrescu #791 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue with width on custom filter component pkmnct/mui-datatables
2 participants
@emil-alexandrescu @pkmnct