Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TableResize - when changing window size resizers moving wrongly or do not move. #1164

Closed
domind opened this issue Jan 20, 2020 · 5 comments
Closed
Assignees
Labels

Comments

@domind
Copy link
Contributor

domind commented Jan 20, 2020

TableResize - when changing window size resizers moving wrongly or do not move.

Expected Behavior

It should move accordingly to window size changes.

Current Behavior

1

Steps to Reproduce (for bugs)

You can check it in this sandbox

Your Environment

Tech Version
Material-UI 4.8.3
MUI-datatables 2.14.0
React 16.12.0

If you confirm that it should be fixed, can write PR, as seems that this will require only some deletion of code in setDividers function.

@gabrielliwerant
Copy link
Collaborator

Looks like a bug to me, thanks for reporting! Let's see how the other PR you have up for resizing goes first, and then I think it'll make sense to tackle this one.

@domind
Copy link
Contributor Author

domind commented Feb 4, 2020

@gabrielliwerant - should I send PR for this one already?

@gabrielliwerant
Copy link
Collaborator

@domind Hm, that might be awkward if it depends on the unmerged PR up now. If so, it's probably best to wait until after that one is released.

@domind
Copy link
Contributor Author

domind commented Feb 4, 2020

Tested it on my end, and it does not depend, so will pass PR for this.

domind added a commit to domind/mui-datatables that referenced this issue Feb 4, 2020
@domind domind mentioned this issue Feb 4, 2020
patorjk added a commit that referenced this issue May 31, 2020
@patorjk
Copy link
Collaborator

patorjk commented Jun 15, 2020

This has been resolved as of version 3.0.1 of the library. You can see an example here:

https://codesandbox.io/s/muidatatables-custom-toolbar-zomv5?file=/index.js

@patorjk patorjk closed this as completed Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants