accept emoji in URLs (fix for #238) #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @adamdavidcole, thanks so much for this PR. Sorry for such a delay in merging. I've basically had no time to even launch my browser and point it to GitHub :/ I think this approach is good though, and it does seem like more and more emojis are appearing in URLs. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #238: Emoji IDNs should be hyperlinked
This solution to accepting emoji in URLs might be too naive, but thought it was worth suggesting.
Emoji are becoming more popular in URLs. For instance, emojipedia accepts emoji based URLs: http://📙.la/🧛🏻♂️.
This adds the emoji unicode range to the
alphaCharsAndMarksStr. I think most end users don't see a difference between letters and emoji, but maybe it belongs in a different class.Demo:
