Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I tried to use version 6.0.0-alpha.0 to get the typescript definitions as added in #555, but they are in
core/src
, which is not currently included in the npm package. This change includes src, so that the types can be used by consuming packages.This also fixes some types that were commented on in the PR but not addressed.
Test plan
I copied the /src folder into
node_modules/@svgr/core/
and verified that types started working correctly in my consuming project.