Handle JSX elements with spread operator with remove-jsx-attribute plugin #231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With the
remove-jsx-attribute
plugin, if you run an element with a spread operator, it would throw an exception because theJSXSpreadAttribute
AST node does not have aname
attribute.In order to allow continue checking for removal of attributes, the PR updates the code so that we make sure that there is a node name to check before we make the comparison to remove it.
Test plan
Wrote a test with a JSX element with spread operator. It failed before the code modification and passes afterwards.