Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#718 server-side-rendering with react 18 #911

Closed
wants to merge 1 commit into from

Conversation

vaukalak
Copy link

Summary

th
The issue #718 mentions, that this library is not usable with react 18. However, this is an update of server-side-rendering example within react 18. And it works fine without errors or warnings. From what I can see you should just use react >=16.3.0: https://github.com/gregberge/loadable-components/blob/main/packages/component/package.json#L37

Test plan

cd packages/component
yarn
yarn dev

open http://localhost:9000. Observe that server-side rendered code is properly hydrated without any warnings:
lodable-components-react-18-ssr

@theKashey theKashey self-requested a review September 15, 2022 10:41
@theKashey
Copy link
Collaborator

The problem with React 18 is more about Suspense. The provided example is not using any "React" orchestration and hence has no issues.

@stale
Copy link

stale bot commented Nov 23, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 23, 2022
@stale stale bot closed this Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants