-
-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: TypeScript definitions #80
Conversation
<App prop1={"1"} prop2={2}/> | ||
); | ||
|
||
getLoadableState(app).then(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only thing, which matters.
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
=======================================
Coverage 88.83% 88.83%
=======================================
Files 15 15
Lines 197 197
Branches 53 53
=======================================
Hits 175 175
Misses 20 20
Partials 2 2 Continue to review full report at Codecov.
|
Thank you very much for that! |
Any timeline when this PR will be published? |
@jbadeau - it was published. |
@jbadeau types are no longer maintained into this repository, please use https://github.com/DefinitelyTyped/DefinitelyTyped instead. |
Would be also nice to publish some example with TypeScript server-side rendering. |
For anyone else looking for how to install the types,
|
And for yarn, |
This should be in the docs I mean, those |
Adding types for TypeScript. implements #79
dtslint is not properly working for the case of '/server' so I had to use a bit "old" syntax for declaration.
Not adding
typecheck:ts
into CI, as long typechecking is failing.dtslint was just created for DefinitelyTyped and few things are bound to DefinitelyTyped.
It asks you to use "new" syntax, dont use "declare modules" and mark all the exports as "exports". Meanwhile in this case tests could not see '/server' and there is no way to use "new" syntax.
For the old syntax it asks not to use exports at all, as result - nothing will work. 💩
So type-checking is red, type-testing is green. And type-testing is the only thing the customers needs.