Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow webpack cache isReady only for initial chunks #568

Merged
merged 2 commits into from
Jun 7, 2020
Merged

Allow webpack cache isReady only for initial chunks #568

merged 2 commits into from
Jun 7, 2020

Conversation

theKashey
Copy link
Collaborator

Summary

Only SSR-ed chunks could be tested for isReady via webpack cache. Others should go through requireAsync and track their process in a internal state variables.

@theKashey theKashey mentioned this pull request May 14, 2020
Closed
@theKashey
Copy link
Collaborator Author

Tested, and it's working 👍
However, I've found an issue with loadable.lib and moment - it's actually not working in production mode. More like webpack/moment related problem like moment is moment node, and {default:moment} in the browser. Result - 💩

@theKashey theKashey mentioned this pull request May 16, 2020
Closed
@prateekr1 prateekr1 mentioned this pull request May 19, 2020
Closed
@7rulnik 7rulnik mentioned this pull request May 24, 2020
Merged
@theKashey theKashey merged commit 6ea00c4 into master Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@theKashey