Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server.d.ts to .npmignore #113

Merged
merged 1 commit into from
Sep 4, 2018

Conversation

lucasterra
Copy link
Contributor

#95 broke TS Definitions for loadable-components/server. That's because server.d.ts is not being exported on npm publish.

This fixes this #112

@codecov
Copy link

codecov bot commented Sep 3, 2018

Codecov Report

Merging #113 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #113   +/-   ##
=======================================
  Coverage   90.45%   90.45%           
=======================================
  Files          15       15           
  Lines         199      199           
  Branches       54       54           
=======================================
  Hits          180      180           
  Misses         17       17           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 682cebe...c280423. Read the comment docs.

@gregberge
Copy link
Owner

Good catch, thanks!

@gregberge gregberge merged commit 240bb8f into gregberge:master Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants