We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi! According to docs browser support is:
v5.x (React v16.3+): IE11, IE 9+ (with Map + Set polyfills), all evergreen browsers
But my project fails on this line https://github.com/smooth-code/loadable-components/blob/d7c3f58059a798dc1d38f95da79f374e998977ad/packages/component/src/loadableReady.js#L44
includes doesn't supported in IE up to ie11
includes
Am i doing something wrong? My project uses razzle boilerplate with loadable-components example: https://github.com/smooth-code/loadable-components/tree/master/examples/razzle
razzle
loadable-components
The text was updated successfully, but these errors were encountered:
Hmm yes you are right, for now you can just include the polyfill. Could you submit a PR to fix it?
Sorry, something went wrong.
By fixing it I mean using indexOf instead of includes.
indexOf
support ie11
9ab2674
I didn't check this, but it seems trivial fixes gregberge#397
fix: support IE 11 without polyfill (#416)
80ee809
Fixes #397
fix: support IE 11 without polyfill (gregberge#416)
9be227d
Fixes gregberge#397
Successfully merging a pull request may close this issue.
🐛 Bug Report
Hi!
According to docs browser support is:
But my project fails on this line https://github.com/smooth-code/loadable-components/blob/d7c3f58059a798dc1d38f95da79f374e998977ad/packages/component/src/loadableReady.js#L44
includes
doesn't supported in IE up to ie11Am i doing something wrong? My project uses
razzle
boilerplate withloadable-components
example: https://github.com/smooth-code/loadable-components/tree/master/examples/razzleThe text was updated successfully, but these errors were encountered: