Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xonsh.xontribs.xontrib-*: init at various #1

Open
wants to merge 6 commits into
base: add_xontrib_pkgs
Choose a base branch
from

Conversation

drmikecrowe
Copy link

Since version 0.14.0, Xonsh moved to including most of its basic
extension functionality in xontribs. Using the existing Xonsh wrapper,
the above listed xontrib packages can now be included with its
extraPackages argument.

xonsh.xontribs.xontrib-vox: init at 0.0.1
A plugin for the xonsh shell allowing manipulation of Python virtual
environments

xonsh.xontribs.xontrib-whole-word-jumping: init at 0.0.1
A plugin for the xonsh shell that adds additional navigation options

xonsh.xontribs.xontrib-jedi
Improved Xonsh's Python completions using jedi

xonsh.xontribs.xontrib-mpl: init at 0.0.2
Matplotlib hooks for xonsh, including 'mpl' alias that displays the current figure on the screen

xonsh.xontribs.xontrib-jupyter: init at 0.3.0
Xonsh jupyter kernel allows to run Xonsh shell code in Jupyter, JupyterLab, Euporia, etc.

xonsh.xontribs.xontrib-fish-completer: init at 0.0.1
Populate rich completions using fish and remove the default bash based completer

xonsh.xontribs.xontrib-bashisms: init at 0.0.5
Bash-like interactive mode extensions for the xonsh shell.

xonsh.xontribs.xontrib-debug-tools: init at 0.0.1
Debug tools for xonsh shell.

xonsh.xontribs.xontrib-abbrevs: init at 0.0.1
Command abbreviations. This expands input words as you type.

xonsh.xontribs.xontrib-distributed: init at 0.0.4
Dask Distributed integration for Xonsh

xonsh.xontribs.xonsh-direnv: init at 1.7.0
Direnv integration for Xonsh## Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

greg-hellings
greg-hellings previously approved these changes Jul 13, 2024
Copy link
Owner

@greg-hellings greg-hellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a number of comments on these, and several of them apply across multiple files.

@greg-hellings greg-hellings self-requested a review July 13, 2024 04:42
@greg-hellings greg-hellings dismissed their stale review July 13, 2024 04:43

This should have requested changes

Copy link
Owner

@greg-hellings greg-hellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mis-clicked the Approve. I meant to hit Request changes.

@drmikecrowe
Copy link
Author

OK, changes pushed -- LMK if they meet the changes requested

@drmikecrowe
Copy link
Author

@greg-hellings -- all PR comments addressed. LMK if you see further issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants