PLANET-6811 Remove default duotones #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: https://jira.greenpeace.org/browse/PLANET-6811 Ref: WordPress/gutenberg#40383 --- Our current `theme.json` option doesn't work in 6.0. You will probably see a validation error in your editor, because `null` is not yet reflected in the official schema, but it does seem to work without issues.
planet-4
added a commit
to greenpeace/planet4-test-iocaste
that referenced
this pull request
Jun 15, 2022
/unhold 3ebf046c-a2e6-42c8-9325-39c40b3361c4
Test instance is ready 🚀🌑 iocaste | admin | blocks report | CircleCI | composer-local.json ⌚ 2022.06.15 09:07:45 |
mleray
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://jira.greenpeace.org/browse/PLANET-6811
Ref: WordPress/gutenberg#40383
Our current
theme.jsonoption doesn't work in 6.0. You will probably see a validation error in your editor, becausenullis not yet reflected in the official schema, but it does seem to work without issues.
Testing
masterbranch in the theme, add an image block. You should be seeing the Duotones button in the formatting toolbar.git checkout -t origin/duotone-falsemake flush(just in case)I haven't tested this with 5.9 yet, but if it creates issues we can hold merging it till the actual upgrade.