PLANET-6652: Extract search filters #1691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lithrel
force-pushed
the
fix/search-taxonomy-6552
branch
from
8d38edc to
0a1d1a6
Compare
Inwerpsel
reviewed
Apr 27, 2022
Extract search filters to their own classes Use consistent taxonomy
lithrel
force-pushed
the
search-extract-filters
branch
from
0f932be to
9bd771d
Compare
Remove tags in search template
Add p4_action type to search filters and template
lithrel
force-pushed
the
search-extract-filters
branch
from
8d989da to
18b2329
Compare
lithrel
changed the title
planet-4
added a commit
to greenpeace/planet4-test-phobos
that referenced
this pull request
May 25, 2022
/unhold 46cfbfc6-0437-4b01-af59-7b39c07aa78d
planet-4
added a commit
to greenpeace/planet4-test-phobos
that referenced
this pull request
Jun 8, 2022
/unhold 5c520759-88b1-455f-a12f-506851a41ceb
Test instance is ready 🚀🌑 phobos | admin | blocks report | CircleCI | composer-local.json ⌚ 2022.06.13 10:25:08 |
planet-4
added a commit
to greenpeace/planet4-test-phobos
that referenced
this pull request
Jun 9, 2022
/unhold 2a441b74-6fe5-4e27-a7b1-644c71c4cd13
Remove act pages filter and various exceptions
lithrel
force-pushed
the
search-extract-filters
branch
from
7f58009 to
6b26ca4
Compare
planet-4
added a commit
to greenpeace/planet4-test-phobos
that referenced
this pull request
Jun 9, 2022
/unhold 0caa8465-dab6-4521-b0cf-692e4ec63387
|
@lithrel is Actions showing up for you locally? I tried various things but couldn't make it work. I replicated my steps on the test instance.
|
Missing action post type in type list Reduce label definition code
planet-4
added a commit
to greenpeace/planet4-test-phobos
that referenced
this pull request
Jun 13, 2022
/unhold bc98010f-ed44-42dd-a561-2e3448b3c99d
|
@comzeradd right, 👍 the post type was missing for the general search args, fixed now 🔧 the "Action" content type appears for your page |
comzeradd
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://jira.greenpeace.org/browse/PLANET-6652
Ref: https://jira.greenpeace.org/browse/PLANET-6797
Ref/ https://jira.greenpeace.org/browse/PLANET-6578
Clarify search code by matching native taxonomy with class structure