fix(get-config): don‘t mutate original config in repo doc

greenkeeperio · Apr 6, 2018 · 98144d1 · 98144d1
1 parent e597e6b
commit 98144d1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/lib/get-config.js b/lib/get-config.js
@@ -10,7 +10,8 @@ module.exports = repository => {
     {}
   )
 
-  return _.defaultsDeep(config, {
+  // Make a copy instead of mutating the original repoDoc config!
+  return _.defaultsDeep(JSON.parse(JSON.stringify(config)), {
     label: 'greenkeeper',
     branchPrefix: 'greenkeeper/',
     ignore: [],

diff --git a/test/jobs/create-initial-branch.js b/test/jobs/create-initial-branch.js
@@ -607,7 +607,7 @@ describe('create initial branch', () => {
       '@finnpauls/dep2': '1.0.0'
     }
 
-    expect.assertions(19)
+    expect.assertions(20)
 
     nock('https://api.github.com')
       .post('/installations/137/access_tokens')
@@ -738,6 +738,8 @@ describe('create initial branch', () => {
       // is no longer in the repo
       const transformedConfigFile = transforms[0].transform()
       const parsedConfigFile = JSON.parse(transformedConfigFile)
+      // Check that we don’t add Greenkeeper system defaults to the actual greenkeeper.json file
+      expect(parsedConfigFile.commitMessages).toBeFalsy()
       expect(parsedConfigFile.groups).toMatchObject({
         build: {
           packages: [