feat(logs): add logs for pr creation fails

greenkeeperio · Aug 14, 2018 · 022d0a2 · 022d0a2
1 parent 914617a
commit 022d0a2
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/jobs/create-group-version-branch.js b/jobs/create-group-version-branch.js
@@ -380,7 +380,9 @@ async function createPr ({ ghqueue, title, body, base, head, owner, repo, log })
       repo
     }))
   } catch (err) {
+    log.warn('Could not create PR', { err })
     if (err.code !== 422) throw err
+
     const allPrs = await ghqueue.read(github => github.pullRequests.getAll({
       base,
       head: owner + ':' + head,

diff --git a/jobs/create-initial-pr.js b/jobs/create-initial-pr.js
@@ -149,7 +149,7 @@ module.exports = async function (
     }
   } catch (err) {
     if (err.code !== 422) {
-      log.error('Could not create initial pr')
+      log.error('Could not create initial pr', {err})
       throw err
     }
 

diff --git a/jobs/create-initial-subgroup-pr.js b/jobs/create-initial-subgroup-pr.js
@@ -112,7 +112,7 @@ module.exports = async function (
     }
   } catch (err) {
     if (err.code !== 422) {
-      log.error('Could not create initial subgroup pr')
+      log.error('Could not create initial subgroup pr', {err})
       throw err
     }
 
@@ -125,8 +125,11 @@ module.exports = async function (
       head: `${owner}:${head}`
     })))[0]
     log.warn('pr was already created', {pullRequestInfo: pr})
-    id = pr.id
-    number = pr.number
+
+    if (pr) {
+      id = pr.id
+      number = pr.number
+    }
   }
 
   await upsert(

diff --git a/jobs/create-version-branch.js b/jobs/create-version-branch.js
@@ -401,7 +401,9 @@ async function createPr ({ ghqueue, title, body, base, head, owner, repo, log })
       repo
     }))
   } catch (err) {
+    log.warn('Could not create PR', { err })
     if (err.code !== 422) throw err
+
     const allPrs = await ghqueue.read(github => github.pullRequests.getAll({
       base,
       head: owner + ':' + head,