Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code aptation to Android 9 #92

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Code aptation to Android 9 #92

wants to merge 3 commits into from

Conversation

magnuscruz
Copy link

No description provided.

hmatalonga
hmatalonga reviewed Apr 21, 2021
View reviewed changes
app/src/main/java/com/hmatalonga/greenhub/Config.java Outdated
@@ -52,9 +52,9 @@
public final class Config {
public static final boolean DEBUG = true;

public static final String SERVER_STATUS_URL = "https://greenhubproject.org/";
public static final String SERVER_STATUS_URL = "http://192.168.1.251:8000/";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local addresses can't be added to the production codebase.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

hmatalonga
hmatalonga reviewed Apr 21, 2021
View reviewed changes
app/src/main/res/xml/network_security_config.xml Outdated
<?xml version="1.0" encoding="utf-8"?>
<network-security-config>
<domain-config cleartextTrafficPermitted="true">
<domain includeSubdomains="true">192.168.1.251</domain>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same situation here with the local address.

hmatalonga
hmatalonga requested changes Apr 21, 2021
View reviewed changes
Copy link
Member

@hmatalonga hmatalonga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Magnus thank you for submitting the improvements for Android 9 it is very helpful. I will ask you to remove the local IP addresses references because they are not used in production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmatalonga hmatalonga hmatalonga requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magnuscruz @hmatalonga @magnus-cruz-csw