-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pubmed citations do not generate properly #210
Comments
See comments below for immediate fix. I apologize for not fixing this sooner. I thought it was a more niche edge case, so I didn't prioritize it. |
Thanks for the quick reponse, and apologies if I'm misunderstanding something here. I updated the
|
I also tried replicating that PR and making requirements.txt unpinned from all minor versions:
Again, a new docker image is built, but it still chokes when importing from pubmed with the same errors. |
Sorry for the string of comments here! It looks like manubot 0.5.6 was released in February, but the PR linked there was just merged Sep 1st (so isn't in a release yet). manubot/manubot@6e6f6a5 Do we need to poke the manubot folks for a new release to resolve this? |
Ack you're right. I saw 0.5.6 on PyPI and assumed it included the fix. Yes, we need to prod them to push this fix. I will do so. |
If you want an immediate fix, I think you can do:
which produces this in
So if you just replace your requirements.txt Manubot line with the above, it hopefully should work. |
That seems to have done the trick for now! I'll keep an eye out for that manubot release. Thanks! |
Unpins all cite process python packages from their exact versions, pins them to **major versions**. This ensures users will be on the latest versions of packages, without breaking changes (assuming the packages follow semver properly), and without having to constantly update their template version (which can be a pain). Closes #210 Addresses #211 FOR THE TEMPLATE MAINTAINER(S) New template version checklist: - [x] I have updated CITATION and CHANGELOG as appropriate. - [x] I have updated lab-website-template-docs as appropriate. - [x] I have checked the testbed as appropriate. --------- Co-authored-by: vincerubinetti <[email protected]>
Manubot 0.6.0 is out on PYPI, fixing the issue. LWT 1.1.6 is out with a change to the python dependency versions. |
Unpins all cite process python packages from their exact versions, pins them to **major versions**. This ensures users will be on the latest versions of packages, without breaking changes (assuming the packages follow semver properly), and without having to constantly update their template version (which can be a pain). Closes greenelab#210 Addresses greenelab#211 FOR THE TEMPLATE MAINTAINER(S) New template version checklist: - [x] I have updated CITATION and CHANGELOG as appropriate. - [x] I have updated lab-website-template-docs as appropriate. - [x] I have checked the testbed as appropriate.
Checks
Link to your website repo
No response
Version of Lab Website Template you are using
1.1.5
Description
Pubmed citations don't appear to be working in the most recent release of lab-website-template. Upon loading a search into
_data/pubmed.yaml
such as this:Manubot seems to choke on it, and while it creates entries, they are missing essentially all key information:
citations.yaml
just looks like this:And the process logs show the following errors:
And so on.
Some research shows that there's an underlying issue with a package manubot depends on:
manubot/manubot#367
And that they appear to have since fixed it. by requiring specific versions of the package in question. Is this fix something that can be pushed into the lab-website-template repo so that pubmed functionality works again?
Thanks!
The text was updated successfully, but these errors were encountered: