Improvements and fixes for test_alive_hosts_only feature #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EOF is expected at some point so no warning should be printed for that case.
ArnoStiefvater
requested review from
jjnicola and
mattmundell
as code owners
ArnoStiefvater
force-pushed
the
imprvmnts
branch
from
8c31a8a
to
3e9a7ae
Compare
mattmundell
approved these changes
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Set source address correctly and do not try to send ARP to unreachable destination when using test_alive_hosts_only feature.
Why:
To get expected behavior.
How:
The correct source address is printed in the debug logs. When trying to send to an unreachable destination a warning log is printed.
Checklist: